feat(robot/client): add support for transform_pcd method#1213
Open
HipsterBrown wants to merge 2 commits intomainfrom
Open
feat(robot/client): add support for transform_pcd method#1213HipsterBrown wants to merge 2 commits intomainfrom
HipsterBrown wants to merge 2 commits intomainfrom
Conversation
Member
|
👋 Thanks for requesting a review from the team! We aim to review PRs within one business day. If this is urgent |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the
transform_pcdmethod on the robot client so users of the SDK can convert point cloud data using the functionality provided by viam-server rather than manually, see https://github.com/viam-modules/sam2-detector/pull/2/changes#diff-62bad4714babfa7480cac98f4e4933f477f7994bbf9b467cac31c91b8d53d3f2R368This is already available in the TypeScript SDK, so just matching parity here.