fix: respond with 500 when a handler throws a non-Error value - #492
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a request that never completes when a handler throws or rejects with a value that is not an
Error.Problem
run()only answers errors that passisError(). If a handler throws a string, a plain object, or rejects with a non-Errorvalue, thecatchbranch does nothing. No response is sent and the client waits until it times out.Changes
run()now always callssendError(). A non-Errorvalue is wrapped in anErrorthat includes the inspected value, so the client gets a 500 and the server logs the stack.throwof a string and aPromise.reject()with a plain object.Testing
Before the change, both new tests fail with a network timeout. After the change, all three suites pass.