fix(chat): preserve markdown whitespace in plain text#604
Open
RSO wants to merge 2 commits into
Open
Conversation
Contributor
|
@RSO is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When I mention a Chat SDK-powered bot on GitHub like this:
The mention doesn't trigger any handling, because the
mdastToStringhelper replaces all newlines with an empty string, so the logs look like this:Summary
Testing
pnpm checkpnpm knippnpm test:workspacepnpm --filter chat testpnpm --filter @chat-adapter/github testpnpm --filter chat typecheckpnpm --filter @chat-adapter/github typecheckNotes
pnpm validatewas attempted and reached the full Turbo test graph, but failed onpackages/integration-tests/src/replay-discord.test.ts(should skip bot's own messages in subscribed threads). Rerunningpnpm --filter @chat-adapter/integration-tests test -- src/replay-discord.test.tspassed, so this appears unrelated to the markdown whitespace change..github/CONTRIBUTING.mdrequires signed commits. This environment has nogpgbinary and no SSH signing identities loaded, so the commit in this PR is currently unsigned and may need to be re-signed before merge.