Repository navigation
Conversation
f3cfa80 asserted that the canonical byte loop contains no `fptosi double` at all, meaning no exact-index round trip. The fixture also coerces its running sum with ToUint32, whose inline fast path legitimately uses `fptosi double ... to i64`, so the test fails on main (aaccbb3) as well; #865 merged before the shards that run it. Assert instead that no `bytes.index` check block is emitted, which keeps the original intent (no unproven-index path for a proven in-bounds induction index).
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
Superseded by #866, which fixed the same byte-loop assertion on main. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#865 merged before its test shards ran (main CI run was cancelled), and its byte-loop assertion
not.toContain("fptosi double")fails on main: the loop index has no index check, but the fixture converts its running sum to uint32 inline, and that conversion legitimately usesfptosi double. The assertion now checks what it means: no index-check blocks (not.toContain("bytes.index")), the same intent as the pre-#842bytes.index.rangeassertion. Test-only change. This red test is what fails theplain/sanshards of every open PR that merges main.