Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2953 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 114 114
Lines 2599 2600 +1
Branches 658 659 +1
=========================================
+ Hits 2599 2600 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isDatethrows aTypeErrorinstead of returningfalsewhen the delimiter used informatis not indelimiters:isValidFormataccepts.as a format delimiter, but the defaultdelimitersare['/', '-']. SoformatDelimiterisundefined,split(undefined)keeps the whole string as one part, and when the input has the same length as the format,dateObj.y/dateObj.mare never set. Inputs of other lengths already returnfalse.Since the format's delimiter isn't an allowed one, no input can match. The fix returns
falsein that case, which is what other mismatched inputs already get. Passingdelimiters: ['.']keeps working as before.Related to #1709 (where
.formats were enabled).Checklist
AI-assistance note: I found this bug and drafted the fix with help from an AI coding assistant, then checked the change and ran the test suite locally.