Repository navigation
Add ISMN validator and test cases - #2952
Open
SiriKatta0701 wants to merge 1 commit into
Open
SiriKatta0701 wants to merge 1 commit into
SiriKatta0701 wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2952 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 114 115 +1
Lines 2599 2618 +19
Branches 658 663 +5
=========================================
+ Hits 2599 2618 +19 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I Changed
For this issue, I added a new ISMN validator to check whether a number follows the correct format and has a valid check digit. I made it work with both the newer 13-digit ISMNs and the older ones that start with M.
I also added support for spaces and hyphens, while making sure the input doesn't have extra separators at the beginning, end, or repeated together.
Testing
I added 32 test inputs to check different valid and invalid ISMNs. These include numbers with incorrect check digits, wrong prefixes, incorrect lengths, and invalid characters. I also tested both the newer and older ISMN formats.
After making the changes, I ran the full test suite and all 324 tests passed.
Files Updated
isISMN.jswith the new validation function.src/index.jsso the validator can be used in the library.test/validators.test.js.Related to #2744.