Repository navigation
fix(isISBN): require an ISBN prefix for ISBN-13 values - #2951
Open
BipinBudhathoki01 wants to merge 1 commit into
Open
BipinBudhathoki01 wants to merge 1 commit into
BipinBudhathoki01 wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2951 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 114 114
Lines 2599 2599
Branches 658 658
=========================================
Hits 2599 2599 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject checksum-valid EAN-13 values that do not use an ISBN prefix.
For example,
isISBN('4006381333931', 13)currently returns true. The ISBN-13 regex accepts any 13 digits, so an ordinary product barcode can pass the existing checksum test. Restricting the prefix to978or979returns false for these values while retaining both ISBN prefix ranges.Reference: International ISBN Agency — What is an ISBN?, which specifies the 978 and 979 prefix elements.
Adds five regression cases covering automatic version detection and the numeric/string legacy and options-object signatures. Controls cover both prefixes, hyphen/space normalization, incorrect checksums, and checksum-valid EAN-13 values outside the ISBN prefixes. Existing ISBN-10 tests remain unchanged. README documents the prefix check.
Validation on Node v24.1.0 / npm 11.3.0:
npm test: builds, lint, and all 328 tests pass.git diff --checkpasses.Compatibility: this intentionally rejects previously accepted EAN-13 values with non-ISBN prefixes. No API, dependency, version, checksum algorithm, or ISBN-10 changes. This validates shape/prefix/checksum, not registration-group assignments or actual publication records. The full Node-version CI matrix has not yet run.
Checklist