Skip to content

fix(isCreditCard): anchor Mastercard regex and require 16 digits (#2717) #2942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tyza66 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(isCreditCard): anchor Mastercard regex and require 16 digits (#2717) #2942

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/isCreditCard.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ const cards = {
dinersclub: /^3(?:0[0-5]|[68][0-9])[0-9]{11}$/,
discover: /^6(?:011|5[0-9][0-9])[0-9]{12,15}$/,
jcb: /^(?:2131|1800|35\d{3})\d{11}$/,
mastercard: /^5[1-5][0-9]{2}|(222[1-9]|22[3-9][0-9]|2[3-6][0-9]{2}|27[01][0-9]|2720)[0-9]{12}$/, // /^[25][1-7][0-9]{14}$/;
mastercard: /^(?:5[1-5][0-9]{14}|(222[1-9]|22[3-9][0-9]|2[3-6][0-9]{2}|27[01][0-9]|2720)[0-9]{12})$/,
unionpay: /^(6[27][0-9]{14}|^(81[0-9]{14,17}))$/,
visa: /^(?:4[0-9]{12})(?:[0-9]{3,6})?$/,
};
Expand Down
28 changes: 28 additions & 0 deletions test/validators.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6635,6 +6635,34 @@ describe('Validators', () => {
});


it('should reject short and partial Mastercard numbers (#2717)', () => {
// The Mastercard pattern's unanchored alternation (`^5[1-5][0-9]{2}|...`)
// used to match any 51-55 prefix regardless of length (#2717).
test({
validator: 'isCreditCard',
valid: [
'5105105105105100',
'5398228707871527',
],
invalid: [
'5108',
'5108 5108 5108 5108 5108',
],
});
test({
validator: 'isCreditCard',
args: [{ provider: 'mastercard' }],
valid: [
'5105105105105100',
],
invalid: [
'5108',
'5108 5108 5108 5108 5108',
],
});
});


it('should validate Union Pay provided credit cards', () => {
test({
validator: 'isCreditCard',
Expand Down
Loading