Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add expect() and expectErr() throwing UnwrapException #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
feat: add expect() and expectErr() throwing UnwrapException #97
Changes from all commits
016c267ed90782434acda2afeadaa5ece5cFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🔵 Trivial | ⚖️ Poor tradeoff
コンビネータ・ネストとの組み合わせテストの追加を検討
expect/expectErr単体の成功・例外系は網羅されていますが、map/andThen/orElseなどのコンビネータと組み合わせた場合や、ネストしたResultに対するexpect/expectErrの挙動を検証するテストが見当たりません。既存のunwrap/unwrapErrにも同種のテストは無いため必須ではありませんが、Rust のResultAPI に倣うなら組み合わせ利用が想定されるため、余裕があれば追加を検討してください。As per path instructions, テストは「エッジケース(Ok/Err 双方、ネスト、map/and_then などのコンビネータ)が網羅されているかを見る」必要があります。
Also applies to: 165-173
🤖 Prompt for AI Agents
Source: Path instructions
Uh oh!
There was an error while loading. Please reload this page.