chmod: report Permission denied instead of No such file when stat fails#12338
Open
c-tonneslan wants to merge 1 commit into
Open
chmod: report Permission denied instead of No such file when stat fails#12338c-tonneslan wants to merge 1 commit into
c-tonneslan wants to merge 1 commit into
Conversation
Path::exists() swallows the underlying io error and returns false on
"can't stat", so chmod was telling people "No such file or directory"
when the real problem was that the parent directory had mode 000:
$ chmod 000 locked && chmod 000 locked/file
chmod: cannot access 'locked/file': No such file or directory # us
chmod: cannot access 'locked/file': Permission denied # GNU
Use try_exists() and surface the PermissionDenied case explicitly. Other
IO errors fall through to the actual chmod call so we still produce a
useful message there.
Closes uutils#9789.
Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9789.
Path::exists()returnsfalsewhenever it can't stat the path — including when the parent directory is unreadable. That makes chmod surface "No such file or directory" in cases where the file is actually there:Swap
exists()fortry_exists()and emit the existingPermissionDeniedvariant when the kind matches. Other IO errors fall through and the actual chmod call surfaces its own message.