sort: don't accept leading '+' in numeric (-n) sort#12336
Open
c-tonneslan wants to merge 1 commit into
Open
Conversation
Rust's f64 parser happily accepts "+1" as 1.0, so the whole-line numeric fast path was treating "+1", "+10", "+2" as numbers and sorting them numerically. GNU sort -n explicitly rejects a leading '+' (that's reserved for -g), so the lines should compare lexicographically and end up in their original order. Reject inputs containing '+' from the fast path so they fall through to the regular comparator, which already does the right thing. Closes uutils#10315. Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rust's
f64parser happily accepts+1as1.0, so the whole-line numeric fast path insort -nwas treating+1,+10,+2as numbers and sorting them numerically. GNU sort-ndoesn't accept a leading+(only-gdoes), so those lines should compare lexicographically and stay in their original order.Reproduces on main:
Fix: exclude inputs containing
+from the fast path so they fall through to the regular comparator, which already rejects+as a sign.Closes #10315.