stat: fix %N quoting of filenames containing control characters#12330
Open
fullwoodenshovel wants to merge 1 commit into
Open
stat: fix %N quoting of filenames containing control characters#12330fullwoodenshovel wants to merge 1 commit into
fullwoodenshovel wants to merge 1 commit into
Conversation
fullwoodenshovel
force-pushed
the
fix-stat-percent-n-control-chars
branch
from
dc54600 to
9b32ed5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
%Nwas outputting raw control characters (e.g. newlines) in filenames instead of escaping them. Fixed by replacing the localquote_file_nameimplementation withuucore::quoting_style::escape_name, which correctly implementsshell-escape-alwaysbehaviour. Added tests for filenames containing single and contiguous newlines.Fixes #9925. More info and examples there.
There is a previous attempt at this fix in #9926, but it only handles
\nspecifically, and doesn't match GNU exactly as it adds a$'...'block around the whole string instead of only around the control characters. This PR instead usesuucore::quoting_style::escape_namewhich correctly handles all control characters consistently with the rest of the codebase and GNU.