Remove deprecated curl_close calls#164
Open
ChiragAgg5k wants to merge 1 commit intomainfrom
Open
Conversation
Greptile SummaryRemoves the single Confidence Score: 5/5This PR is safe to merge — it removes a no-op deprecated call with no behavioral impact. Single-line removal of a deprecated, no-op function call. No logic changes, no security implications, and the repository has no remaining curl_close usages. No files require special attention. Important Files Changed
Reviews (1): Last reviewed commit: "Remove deprecated curl_close calls" | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes calls to
curl_close(). Since PHP 8.0, cURL handles areCurlHandleobjects andcurl_close()no longer has an effect; handles are released by object lifetime instead. Removing these calls avoids noisy PHP 8.5 deprecation warnings without changing behavior for supported PHP versions.Test Plan
php -lon changed PHP files where applicable.curl_close(...)calls remain in this repository.Related PRs and Issues
N/A
Have you read the Contributing Guidelines on issues?
Yes.