Skip to content

Remove deprecated curl_close calls#164

Open
ChiragAgg5k wants to merge 1 commit intomainfrom
codex/remove-curl-close-php85
Open

Remove deprecated curl_close calls#164
ChiragAgg5k wants to merge 1 commit intomainfrom
codex/remove-curl-close-php85

Conversation

@ChiragAgg5k
Copy link
Copy Markdown
Member

What does this PR do?

Removes calls to curl_close(). Since PHP 8.0, cURL handles are CurlHandle objects and curl_close() no longer has an effect; handles are released by object lifetime instead. Removing these calls avoids noisy PHP 8.5 deprecation warnings without changing behavior for supported PHP versions.

Test Plan

  • Ran php -l on changed PHP files where applicable.
  • Confirmed no curl_close(...) calls remain in this repository.

Related PRs and Issues

N/A

Have you read the Contributing Guidelines on issues?

Yes.

@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented Apr 29, 2026

Greptile Summary

Removes the single curl_close($curl) call from the finally block in S3.php. Since PHP 8.0, CurlHandle objects are freed automatically when they go out of scope, so this call is a no-op and will emit a deprecation warning in PHP 8.5. No curl_close calls remain in the repository after this change.

Confidence Score: 5/5

This PR is safe to merge — it removes a no-op deprecated call with no behavioral impact.

Single-line removal of a deprecated, no-op function call. No logic changes, no security implications, and the repository has no remaining curl_close usages.

No files require special attention.

Important Files Changed

Filename Overview
src/Storage/Device/S3.php Removes the deprecated curl_close($curl) call from the finally block; no functional change since PHP 8.0+ releases cURL handles via object lifetime.

Reviews (1): Last reviewed commit: "Remove deprecated curl_close calls" | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant