Skip to content

Remove deprecated curl_close calls#118

Open
ChiragAgg5k wants to merge 2 commits intomainfrom
codex/remove-curl-close-php85
Open

Remove deprecated curl_close calls#118
ChiragAgg5k wants to merge 2 commits intomainfrom
codex/remove-curl-close-php85

Conversation

@ChiragAgg5k
Copy link
Copy Markdown
Member

What does this PR do?

Removes calls to curl_close(). Since PHP 8.0, cURL handles are CurlHandle objects and curl_close() no longer has an effect; handles are released by object lifetime instead. Removing these calls avoids noisy PHP 8.5 deprecation warnings without changing behavior for supported PHP versions.

Test Plan

  • Ran php -l on changed PHP files where applicable.
  • Confirmed no curl_close(...) calls remain in this repository.

Related PRs and Issues

N/A

Have you read the Contributing Guidelines on issues?

Yes.

@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented Apr 29, 2026

Greptile Summary

Removes two curl_close() calls from Adapter.php — one in the single-request request() method and one inside the requestMulti() response loop. Since PHP 8.0, CurlHandle objects are released by object lifetime and curl_close() is a no-op; PHP 8.5 will emit deprecation warnings for it, so the removal is correct and has no behavioral impact on supported PHP versions.

Confidence Score: 5/5

This PR is safe to merge — it removes no-op calls with no behavioral change.

The change is a straightforward removal of two deprecated no-op calls. No logic is altered; behavior is identical on PHP 8.0+. No security, data, or correctness concerns.

No files require special attention.

Important Files Changed

Filename Overview
src/Utopia/Messaging/Adapter.php Removes two curl_close() calls that became no-ops in PHP 8.0 and will trigger deprecation warnings in PHP 8.5; functionally equivalent for supported PHP versions.

Reviews (2): Last reviewed commit: "Clean up curl_close removal formatting" | Re-trigger Greptile

Comment thread src/Utopia/Messaging/Adapter.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant