Skip to content

Remove deprecated curl_close calls#47

Open
ChiragAgg5k wants to merge 1 commit intomainfrom
codex/remove-curl-close-php85
Open

Remove deprecated curl_close calls#47
ChiragAgg5k wants to merge 1 commit intomainfrom
codex/remove-curl-close-php85

Conversation

@ChiragAgg5k
Copy link
Copy Markdown
Member

What does this PR do?

Removes calls to curl_close(). Since PHP 8.0, cURL handles are CurlHandle objects and curl_close() no longer has an effect; handles are released by object lifetime instead. Removing these calls avoids noisy PHP 8.5 deprecation warnings without changing behavior for supported PHP versions.

Test Plan

  • Ran php -l on changed PHP files where applicable.
  • Confirmed no curl_close(...) calls remain in this repository.

Related PRs and Issues

N/A

Have you read the Contributing Guidelines on issues?

Yes.

@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented Apr 29, 2026

Greptile Summary

Removes the now-deprecated curl_close() calls from all four cURL-based adapters. Since PHP 8.0, CurlHandle objects are cleaned up by object lifetime rather than an explicit close call, and PHP 8.5 will emit deprecation warnings for any remaining curl_close() invocations. The change is correct and consistent across all affected adapters.

Confidence Score: 5/5

Safe to merge — purely removes a no-op deprecated call with no behavioral change.

All four changes are identical one-line deletions of a call that has had no effect since PHP 8.0. No logic is altered, no resources are leaked, and the fix is applied consistently across every affected adapter.

No files require special attention.

Important Files Changed

Filename Overview
src/Logger/Adapter/AppSignal.php Removes \curl_close($ch) — correct cleanup of a no-op deprecated in PHP 8.5
src/Logger/Adapter/LogOwl.php Removes \curl_close($ch) — same pattern, no behavioral change
src/Logger/Adapter/Raygun.php Removes \curl_close($ch) — same pattern, no behavioral change
src/Logger/Adapter/Sentry.php Removes \curl_close($ch) — same pattern, no behavioral change

Reviews (1): Last reviewed commit: "Remove deprecated curl_close calls" | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant