chore: allow utopia-php/cache 2.0.* alongside 1.0.*#64
Conversation
Greptile SummaryThis PR widens the
Confidence Score: 4/5Safe to merge; the change is a one-line constraint widening with no logic modifications and the consumed Cache API surface is reported unchanged in 2.0. The constraint widening is minimal and the
Important Files Changed
Reviews (1): Last reviewed commit: "chore: allow utopia-php/cache 2.0.* alon..." | Re-trigger Greptile |
| "php": ">=8.2", | ||
| "utopia-php/validators": "0.*", | ||
| "utopia-php/cache": "1.0.*" | ||
| "utopia-php/cache": "1.0.* || 2.0.*" |
There was a problem hiding this comment.
CI does not validate both cache versions
The test plan checkbox ("CI passes against both cache 1.0.x and 2.0.x") is unchecked, and the existing test.yml workflow has no matrix axis for cache version. composer install will resolve to the highest matching version (2.0.*), so 1.0.x is never installed and exercised post-merge. Adding a cache-versions: ['1.0.*', '2.0.*'] matrix dimension and running composer require utopia-php/cache:${{ matrix.cache-versions }} --no-update before composer install would verify both constraints are actually satisfied.
What
Widen the
utopia-php/cacheconstraint from1.0.*to1.0.* || 2.0.*.Why
utopia-php/cache2.0.0 was released (release notes). It bumps the PHP floor to>=8.2(matches this package), adds aCircuitBreakeradapter and aFeature\Telemetrypropagation contract — all additive. TheUtopia\Cache\Cachetype used insrc/Domains/Cache.phpis unchanged.Allowing both 1.0.x and 2.0.x lets downstream consumers (e.g. appwrite/appwrite) pick up cache 2.0 without forcing existing users off 1.0.x.
Test plan