[dlebedynskyi]

I ran into this in a monorepo where uniwind is a workspace package. After #676, two apps' Metro dev servers running at the same time kept rebuilding each other, because each entry now watched the generated uniwind.css that the other server kept rewriting. Clode did the most of the work bellow.

This follows up #676. When uniwind is linked instead of installed, the native development entry requires uniwind.css. That's the file the entry's own transform rewrites. Linked setups include a workspace package (like the examples in this repo), npm link, or a file: dependency. If two Metro servers with different theme lists run at once, each one's writes rebuild the other, and it never stops.

On main (9fc9b40), I added an hmr-tokens.css import to apps/expo-example/global.css and fetched the iOS dev bundle. These are the stylesheets the CSS entry module depends on:

global.css -> ["hmr-tokens.css", "../../packages/uniwind/uniwind.css"]

apps/bare behaves the same way: src/global.css -> ["src/hmr-tokens.css", "../../packages/uniwind/uniwind.css"].

Next I ran apps/expo-example (light, dark, premium) alongside a copy of it with one extra theme (extraThemes: ['premium', 'ocean']). Each ran expo start from its own directory, with an HMR client registered for its iOS bundle. I counted the HMR updates that carried modules and the writes to packages/uniwind/uniwind.css:

window	uniwind.css writes	rebuilds, expo-example	rebuilds, copy
30 s after start, no edits	427	233	218
30 s after one token edit in expo-example	445	243	230
next 15 s, no edits	212	118	108

This keeps going until one of the servers stops. Each rebuild runs the Tailwind compile for the entry again.

A single server pays once. On a fresh install the shipped artifact doesn't match the app's themes (expo-example adds premium), so the first transform rewrites it. When the HMR client connects, Metro handles that change and transforms the entry a second time.

Cause

#676 requires every stylesheet Tailwind reports through onDependency that ends in .css and isn't under node_modules. Tailwind's resolver follows symlinks. So when node_modules/uniwind is a link, @import 'uniwind' is reported by its real path, packages/uniwind/uniwind.css, and that passes the filter. It's the same file generateArtifacts(cssArtifactPath) writes at the start of the transform.

Once the artifact is a module in the graph, Metro handles every write to it as a change, and the uncached entry gets transformed again, which regenerates the artifact. With one theme list, the second write has identical content and is skipped. With two servers, each writes its own themes, which the other sees as a change.

Fix

isImportedStylesheet keeps the existing rules and also drops the stylesheet whose real path matches the generated artifact's. Both sides are resolved, so the check still works when the artifact path itself goes through a link. Local stylesheets and those of linked workspace packages are still required, so token edits still hot reload. I also added a line about this to CONTEXT.md.

Testing

• tests/native/bundler/transformer.test.ts sets up a linked layout in a temporary directory: node_modules/uniwind and node_modules/brand link into packages/, next to a regular node_modules/theme. It compiles an entry that imports all three plus a local tokens.css with Tailwind, then checks which reported stylesheets the entry keeps (tokens.css and brand.css). It covers the artifact path given as a real path and as a path through the link. With the old filter, both cases fail because they keep packages/uniwind/uniwind.css. A plain string comparison passes the real-path case but fails the linked one.
• I repeated the live run with the fix. The entries now require only hmr-tokens.css.
  • With both Expo servers running, nothing rebuilt and the artifact wasn't written, both in the 30 s after start and in the final 15 s.
  • Each token edit rebuilt the edited server once, with the new token, and didn't rebuild the other one. The other server's HMR client only got empty updates.
  • A single server no longer transforms the entry a second time at startup.
• I ran the CI steps locally: install, build, type checks, lint, format, circular check, and bun run test (native 205, web 48, e2e 9, types). I also exported apps/expo-example for iOS, Android and web, built apps/vite-example, and bundled apps/bare.

For the two-server run I used a second Expo app, not apps/bare. The bare app's React Native CLI runs its own Metro 0.84, while uniwind patches the root Metro 0.85, so Metro doesn't re-run the bare entry on file changes. With apps/expo-example and apps/bare together, the artifact was written three times at startup, each server rebuilt once, and then it stopped. The bare entry still requires the artifact.

Who's affected

This affects native development builds with Metro where uniwind resolves outside node_modules:

• a workspace package in a monorepo (workspace:*, as in this repo)
• npm link, or a file:/link: dependency that's installed as a symlink

Regular installs aren't affected because Tailwind reports a path under node_modules, and that includes pnpm's node_modules/.pnpm. Production builds and web don't add these requires, so they aren't affected either.

The endless rebuilds need two or more Metro servers that share one uniwind copy and use different theme lists, for example two apps in the same monorepo. A single server transforms its entry one extra time at startup whenever the installed artifact doesn't match its themes.

Summary by CodeRabbit

• Bug Fixes
  • Metro development builds no longer include the generated uniwind.css artifact among imported stylesheet dependencies, including when it is referenced through a linked path.
  • Other imported local stylesheets continue to be collected on each compile, so changes to those styles remain reflected in development builds.

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: 3d76f587-3baf-4860-82b3-2c0f6e934d5c

Commits

Reviewing files that changed from the base of the PR and between 848144c and 27c3511.

Files selected for processing: 3

• CONTEXT.md
• packages/uniwind/src/bundler/adapters/metro/transformer.ts
• packages/uniwind/tests/native/bundler/transformer.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

Walkthrough

Metro’s development dependency collector now excludes the generated uniwind.css artifact by comparing resolved paths. Tests cover both real and linked artifact paths and verify that other local CSS dependencies remain included.

Changes: Metro stylesheet dependency filtering

Layer / File(s)	Summary
Filter and dependency collection packages/uniwind/src/bundler/adapters/metro/transformer.ts, packages/uniwind/tests/native/bundler/transformer.test.ts, CONTEXT.md	The transformer excludes the generated artifact when its resolved path matches the artifact path. Tests check real and linked paths and confirm other imported local stylesheets remain in the collected dependencies.

Priority: Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Possibly related PRs

• uni-stack/uniwind#676: Adds the imported-stylesheet dependency path that this change filters.
• uni-stack/uniwind#721: Changes Metro traversal behavior for CSS entries marked css.skipCache, which is related to CSS entry rebuilds.

Suggested reviewers: brentlok, fendyk

Merge Risk: Minimal · up to 27c35

No actionable merge-blocking risk remains from this change.

Pre-merge checks: 5

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly and concisely describes the main change: Metro now skips the generated uniwind.css when tracking imported CSS.
Docstring Coverage		No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within survi…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 2 files. (1 skipped: 1 unsupported.)

Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[greptile-apps]

Confidence Score: 5/5

[Medium impact] The PR appears safe to merge.

Summary

Native Metro development builds now exclude the generated uniwind.css from imported stylesheet dependencies.

• Metro stops watching the artifact its CSS entry rewrites.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Generate CSS artifact] --> B[Compile entry with Tailwind]
    B --> C{Native development build?}
    C -->|No| G[Keep existing output behavior]
    C -->|Yes| D{Local CSS other than artifact?}
    D -->|Yes| E[Add Metro dependency]
    D -->|No| F[Skip dependency]

Loading

_{Reviews (1) · Last reviewed commit: "fix(metro): skip the generated uniwind.c..." · Reviewed by Greptile}

[Brentlok]

It could be simplified

Suggested change

	// Local stylesheets a development entry requires, so editing one re-runs its transform. When uniwind is linked
	// (a workspace package, `npm link`), `@import 'uniwind'` resolves to the generated artifact outside node_modules.
	// Requiring it would rebuild the entry after each write, and Metro servers with different themes after each other's.
	// Exclude the generated artifact to prevent rebuild loops when uniwind is linked.