Convert pf coil vars to dataclass#4256
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4256 +/- ##
==========================================
- Coverage 50.46% 50.27% -0.20%
==========================================
Files 151 151
Lines 29502 29386 -116
==========================================
- Hits 14889 14773 -116
Misses 14613 14613 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
66 tasks
clmould
force-pushed
the
PF-coil-dataclass
branch
from
08e7c66 to
e6ff553
Compare
clmould
force-pushed
the
PF-coil-dataclass
branch
from
e6ff553 to
29401e1
Compare
timothy-nunn
approved these changes
May 18, 2026
Comment on lines
1123
to
+1187
| @@ -1177,15 +1176,15 @@ def scan_select(self, nwp, swp, iscn): | |||
| case 61: | |||
| rebco_variables.copperaoh_m2_max = swp[iscn - 1] | |||
| case 62: | |||
| pfcoil_variables.coheof = swp[iscn - 1] | |||
| self.data.pf_coil.j_cs_flat_top_end = swp[iscn - 1] | |||
| case 63: | |||
| self.data.build.dr_cs = swp[iscn - 1] | |||
| case 64: | |||
| pfcoil_variables.ohhghf = swp[iscn - 1] | |||
| self.data.pf_coil.f_z_cs_tf_internal = swp[iscn - 1] | |||
| case 65: | |||
| self.data.cs_fatigue.n_cycle_min = swp[iscn - 1] | |||
| case 66: | |||
| pfcoil_variables.oh_steel_frac = swp[iscn - 1] | |||
| self.data.pf_coil.f_a_cs_turn_steel = swp[iscn - 1] | |||
Collaborator
There was a problem hiding this comment.
Weird that these were missed during the variable rename. Shows how beneficial this new data structure will be to catching bugs!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
I confirm that I have completed the following checks: