[codex] Fix discussion and suggestion regressions#4945
Open
felixfeng33 wants to merge 18 commits intomainfrom
Open
[codex] Fix discussion and suggestion regressions#4945felixfeng33 wants to merge 18 commits intomainfrom
felixfeng33 wants to merge 18 commits intomainfrom
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 1bba8be The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Keep inline-void deletion atomic, reuse suggestion ids across inline boundaries, move link coverage to real app integration tests, and patch the deleteSuggestion test harness so check stays green.
Keep expanded selection delete and replace flows progressing across mention-shaped inline voids, add regressions for delete and insertText, and carry the generated next-env route typing update already present in the worktree.
Checkpoint the current no-package-use-client experiments across app registry and React surface imports before the next round of build debugging.
dosubot
bot
added
size:L
zbeyens
reviewed
Apr 13, 2026
zbeyens
reviewed
Apr 14, 2026
| "p:tsdown": "cd ${INIT_CWD:-.} && pnpm exec tsdown --config=${PROJECT_CWD:-.}/tooling/config/tsdown.config.ts --log-level warn", | ||
| "p:typecheck": "tsc -p ./tsconfig.json", | ||
| "prepare": "bun x skiller@latest apply", | ||
| "prepare": "if [ -f .agents/skiller.toml ] || [ -f .claude/skiller.toml ]; then bun x skiller@latest apply; else echo '[prepare] skipping skiller apply: no skiller config found'; fi", |
dosubot
bot
added
size:M
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR simplifies discussion UI plumbing and fixes a batch of suggestion regressions across block and inline editing flows.
What changed
Add: Paragraphsuggestionsapps/www/src/__tests__/package-integrationand documented the new suggestion edge cases indocs/solutions/Validation
pnpm check