Refactor componentWillReceiveProps by DiegoGorgazzi · Pull Request #1253 · uber/react-vis

DiegoGorgazzi · 2019-10-18T13:05:28Z

Refactored componentWillReceiveProps to work with componentDidUpdate

Fixes #1084 and #1245

CLAassistant · 2019-10-18T13:05:49Z

All committers have signed the CLA.

cesrjimenez · 2019-11-23T06:30:19Z

Hey y'all when will this be merged?

jota12x · 2019-12-11T11:13:12Z

Hello, any update on this issue? Thanks in advance

kanzelm3 · 2019-12-17T16:36:03Z

I also would like this to be merged. Can we get an update? Seeing an issue where the FlexibleXYPlot is not resizing properly when paired with Suspense because componentWillReceiveProps fires before the display: none !important; is removed from the suspended component, which means it sets the width and height to 0.

gartenfeld · 2020-02-12T16:30:23Z

👍

* upgrades to antd to v4 * upgrades to react@16.13.10 * upgrades to react-router to v5 Unresolved: * `componentWillReceiveProps` warnings from `react-vis` uber/react-vis#1253 * search name space truncates some options like `conferen...` ant-design/ant-design#21754 * `componentWillMount` warnings from `react-helmet` nfl/react-helmet#413 * `componentWillMount` warnings from `react-loadable` jamiebuilds/react-loadable#220 * `Cannot update a component from inside the function body of a different component.` worning from `antd` ant-design/ant-design#21800

INSPIR-3203 * upgrades to antd to v4 * upgrades to react@16.13.10 * upgrades to react-router to v5 Unresolved: * `componentWillReceiveProps` warnings from `react-vis` uber/react-vis#1253 * search name space truncates some options like `conferen...` ant-design/ant-design#21754 * `componentWillMount` warnings from `react-helmet` nfl/react-helmet#413 * `componentWillMount` warnings from `react-loadable` jamiebuilds/react-loadable#220 * `Cannot update a component from inside the function body of a different component.` worning from `antd` ant-design/ant-design#21800

* upgrades to antd to v4 * fixes UX problems with date range picker: INSPIR-3203 * reduces bundle size by removing unnecessary icons: INSPIR-3228 * upgrades to react@16.13.10 * upgrades to react-router to v5 Unresolved: * `componentWillReceiveProps` warnings from `react-vis` uber/react-vis#1253 * search name space truncates some options like `conferen...` ant-design/ant-design#21754 * `componentWillMount` warnings from `react-helmet` nfl/react-helmet#413 * `componentWillMount` warnings from `react-loadable` jamiebuilds/react-loadable#220 * `Cannot update a component from inside the function body of a different component.` worning from `antd` ant-design/ant-design#21800

* upgrades to antd to v4 * fixes UX problems with date range picker: INSPIR-3203 * reduces bundle size by removing unnecessary icons: INSPIR-3228 * upgrades to react@16.13.10 * upgrades to react-router to v5 Unresolved: * `componentWillReceiveProps` warnings from `react-vis` uber/react-vis#1253 * search name space truncates some options like `conferen...` ant-design/ant-design#21754 * `componentWillMount` warnings from `react-helmet` nfl/react-helmet#413 * `componentWillMount` warnings from `react-loadable` jamiebuilds/react-loadable#220 * `Cannot update a component from inside the function body of a different component.` worning from `antd` ant-design/ant-design#21800 * `componentWillReceiveProps` warnings from `react-quill` zenoamaro/react-quill#549

Xiot · 2020-05-31T16:26:44Z

Sorry all for the terrible response time.
As you may have been aware, development on react-vis was stalled for some time.
We are getting back into it however, as we are focusing on modernizing it a bit and putting a focus on performance.

I've rebased and fixed some tests over this this PR (that is based on this one) #1343

jrdzha · 2020-11-30T19:22:38Z

@Xiot Is there any update on when this can be merged? This issue is becoming more and more pressing for us! Thanks!

velusgautam · 2021-01-05T09:09:47Z

showcase/examples/force-directed-graph/force-directed-graph.js

-    this.setState({
-      data: generateSimulation(nextProps)
-    });
+  componentDidUpdate(prevProps, prevState, snapshot) {


why snapshot parameter is declared if it's not used inside componentDidUpdate. Remove unused parameters.

velusgautam · 2021-01-05T09:10:20Z

showcase/examples/responsive-vis/responsive-scatterplot.js

-        nextProps.height
-      )
-    });
+  componentDidUpdate(prevProps, prevState, snapshot) {


Remove unused parameters.

velusgautam · 2021-01-05T09:10:35Z

src/make-vis-flexible.js


-    componentWillReceiveProps() {
-      this._onResize();
+    componentDidUpdate(prevProps, prevState, snapshot) {


Remove unused parameters.

velusgautam · 2021-01-05T09:10:47Z

src/plot/series/arc-series.js


-  componentWillReceiveProps(nextProps) {
-    this.setState({scaleProps: this._getAllScaleProps(nextProps)});
+  componentDidUpdate(prevProps, prevState, snapshot) {


Remove unused parameters.

velusgautam · 2021-01-05T09:10:57Z

src/plot/xy-plot.js

-        scaleMixins: nextScaleMixins,
-        data: nextData
-      });
+  componentDidUpdate(prevProps, prevState, snapshot) {


Remove unused parameters.

velusgautam · 2021-01-05T09:11:29Z

src/treemap/index.js

-      scales: _getScaleFns(props),
-      ...getInnerDimensions(props, props.margin)
-    });
+  componentDidUpdate(prevProps, prevState, snapshot) {


Remove unused parameters.

DiegoGorgazzi added 3 commits October 17, 2019 22:31

Rebuild npm sass-node for Windows 64-bit

bb7193f

Refactor componentWillReceiveProps

bc70392

Fix props replacing componentWillReceiveProps

c7babaf

dirkdevriendt mentioned this pull request Nov 17, 2019

React StrictMode causes warnings esnet/react-timeseries-charts#368

Open

Xiot mentioned this pull request May 31, 2020

Refactor component will receive props #1343

Open

velusgautam reviewed Jan 5, 2021

View reviewed changes

velusgautam suggested changes Jan 5, 2021

View reviewed changes

Conversation

DiegoGorgazzi commented Oct 18, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CLAassistant commented Oct 18, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cesrjimenez commented Nov 23, 2019

Uh oh!

jota12x commented Dec 11, 2019

Uh oh!

kanzelm3 commented Dec 17, 2019

Uh oh!

gartenfeld commented Feb 12, 2020

Uh oh!

Xiot commented May 31, 2020

Uh oh!

jrdzha commented Nov 30, 2020

Uh oh!

velusgautam Jan 5, 2021

Choose a reason for hiding this comment

Uh oh!

velusgautam Jan 5, 2021

Choose a reason for hiding this comment

Uh oh!

velusgautam Jan 5, 2021

Choose a reason for hiding this comment

Uh oh!

velusgautam Jan 5, 2021

Choose a reason for hiding this comment

Uh oh!

velusgautam Jan 5, 2021

Choose a reason for hiding this comment

Uh oh!

velusgautam Jan 5, 2021

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Comments

DiegoGorgazzi commented Oct 18, 2019 •

edited

Loading

CLAassistant commented Oct 18, 2019 •

edited

Loading