fix(sensor): honor CLI display limit - #119
Open
sanjayy0612 wants to merge 2 commits into
Open
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issue: Closes #118
What changed?
--limitvalue intoAgentObserver.display_summary().AgentEvent.get_summary()representation.--limit 0as disabling the preview and reject negative values during argument parsing.Why?
The CLI advertised
--limitas controlling the number of displayed entries, but the value was never consumed. Every value therefore produced the same aggregate-only output.How did you test it?
.venv/bin/pytest -q— 128 passed.venv/bin/ruff check adr_sensor/git diff --checkPotential risks
Low. The default CLI output now includes the two entry summaries the existing default limit promised. API callers can pass
limit=0to retain aggregate-only output. Entry ordering is newest first and normalizes naive timestamps as UTC through the existing timestamp utility.