Fix for success handler for gdpr-privacy-preferences-frm submission#244
Open
codereviewvideos wants to merge 1 commit intotrewknowledge:developfrom
Open
Fix for success handler for gdpr-privacy-preferences-frm submission#244codereviewvideos wants to merge 1 commit intotrewknowledge:developfrom
codereviewvideos wants to merge 1 commit intotrewknowledge:developfrom
Conversation
…ssion * Removes unused local variable * Found `response.status` is undefined, so use `xhr.status` check instead - however may not be needed * Force `window.location.reload` to load page from server, rather than local cache It may be that the `200 === xhr.status` check is not required. This is the success handler function, so a successful outcome is assumed(?) I haven't updated the `else` / `displayNotification` function, as I'm not sure what the expected contents of the `response.data...` object would be. Perhaps hardcoded with translated error strings?
This was referenced Feb 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
response.statusis undefined, so usexhr.statuscheck instead - however may not be neededwindow.location.reloadto load page from server, rather than local cacheIt may be that the
200 === xhr.statuscheck is not required. This is the success handler function, so a successful outcome is assumed(?)I haven't updated the
else/displayNotificationfunction, as I'm not sure what the expected contents of theresponse.data...object would be. Perhaps hardcoded with translated error strings?