Repository navigation
config: s3: add storage_class, requester_pays, object_tags, extra_s3_args - #11123
Open
Jenia3377543 wants to merge 1 commit into
Open
Jenia3377543 wants to merge 1 commit into
Jenia3377543 wants to merge 1 commit into
Conversation
…args Allow the S3 remote write options added in dvc-s3 so they can be set with `dvc remote modify`. Without these schema entries DVC rejects the keys with "extra keys not allowed". `requester_pays` is validated as a boolean and defaults to false; the others are free-form strings interpreted by dvc-s3. Fixes treeverse#11122 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11123 +/- ##
==========================================
+ Coverage 90.68% 90.98% +0.30%
==========================================
Files 504 505 +1
Lines 39795 41153 +1358
Branches 3141 3263 +122
==========================================
+ Hits 36087 37442 +1355
- Misses 3042 3072 +30
+ Partials 666 639 -27 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Author
|
Note for reviewers: the |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the S3 remote write options from treeverse/dvc-s3#173 to the config
schema, so
dvc remote modifyaccepts them instead of failing with"extra keys not allowed".
storage_class,object_tags,extra_s3_args: strings, interpreted by dvc-s3requester_pays: boolean, defaultfalseFixes #11122
Related:
Testing
tests/unit/test_config.py(load and validate all fouroptions;
requester_paysdefault)pytest tests/unit/test_config.pypasses; pre-commit hooks (ruff, mypy,codespell) pass
dvc remote modify myremote requester_pays maybeis rejected🤖 Generated with Claude Code