fix(magic): handle null encoding to prevent decode TypeError#3447
Open
KevinLiebergen wants to merge 1 commit intotrailofbits:masterfrom
Open
fix(magic): handle null encoding to prevent decode TypeError#3447KevinLiebergen wants to merge 1 commit intotrailofbits:masterfrom
KevinLiebergen wants to merge 1 commit intotrailofbits:masterfrom
Conversation
Ninja3047
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a
TypeErrorthat occurs when PolyFile processes certain binary files (specifically observed with PNG, JPG, and GIF images).The Problem: In
polyfile/magic.py, thePlainTextTest.testmethod useschardet.UniversalDetectorto guess the encoding of a file. In some cases, the detector returns a confidence score higher than the minimum threshold but sets theencodingresult toNone.When this happens, the following line triggers a crash because
decode()expects a string:The Fix: Added a check to ensure
detector.result["encoding"]is notNonebefore attempting to use it for decoding. If it isNone, the test correctly falls back to aFailedTest, allowing PolyFile to continue its analysis instead of exiting with a traceback.Verification: Verified by running
polyfileagainst several image files that previously triggered the crash. The analysis now completes successfully for all files.