Skip to content

feat: add pre commit config and fix codespell issues#2159

Merged
waketzheng merged 2 commits intotortoise:developfrom
waketzheng:main
Apr 6, 2026
Merged

feat: add pre commit config and fix codespell issues#2159
waketzheng merged 2 commits intotortoise:developfrom
waketzheng:main

Conversation

@waketzheng
Copy link
Copy Markdown
Contributor

@waketzheng waketzheng commented Mar 29, 2026

Description

  1. Add .pre-commit-config.yaml to support lint code by prek run --all-files without creating a virtual environment
  2. Fix typos that detected by the codespell hook

Motivation and Context

Improve contributor experience

How Has This Been Tested?

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added the changelog accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 29, 2026

Merging this PR will not alter performance

✅ 24 untouched benchmarks


Comparing waketzheng:main (e656ce9) with develop (e1eb507)

Open in CodSpeed

Copy link
Copy Markdown
Contributor

@henadzit henadzit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see pre-commit config in the PR. Did you forget to include it?

@waketzheng
Copy link
Copy Markdown
Contributor Author

I don't see pre-commit config in the PR. Did you forget to include it?

Thanks for your review. Done.

@waketzheng waketzheng requested a review from henadzit April 3, 2026 16:21
pyproject.toml Outdated
"sanic-testing",
# Sample integration - Starlette
"starlette",
"starlette<1.0",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can revert this change also (and update uv.lock accordingly)?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can revert this change also (and update uv.lock accordingly)?

You are right. Reverted.

Copy link
Copy Markdown
Contributor

@seladb seladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waketzheng waketzheng merged commit a394ab2 into tortoise:develop Apr 6, 2026
47 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants