Migrate persistent-sorted-set to org.replikativ fork#494
Closed
BuddhiLW wants to merge 1 commit intotonsky:masterfrom
Closed
Migrate persistent-sorted-set to org.replikativ fork#494BuddhiLW wants to merge 1 commit intotonsky:masterfrom
BuddhiLW wants to merge 1 commit intotonsky:masterfrom
Conversation
The original `persistent-sorted-set/persistent-sorted-set` artifact appears to be unmaintained. The actively maintained fork at `org.replikativ/persistent-sorted-set` 0.3.118 preserves the same `me.tonsky.persistent-sorted-set` namespace and is API-compatible. This resolves classpath conflicts in projects that combine DataScript with Datahike (which already depends on the replikativ fork), avoiding duplicate artifacts with different group IDs for the same library. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Owner
|
Hey, thanks for opening the issue. I spoke with @whilo about the fork, for me it’s too much work to merge or even switch to it. If it’s as simple as changing a dependency then you can do it in your own deps.edn with :exclude, but if it’s not I am not prepared at the moment to do the migration. So we decided that they will keep working on their fork as a separate project (which is I think for the better: it seems far ahead of PSS). Namespace wise, I think two different libraries should provide two different namespaces, but they should change it IMO |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
persistent-sorted-set/persistent-sorted-set 0.3.0toorg.replikativ/persistent-sorted-set 0.3.118deps.ednandproject.cljMotivation
The original
persistent-sorted-set/persistent-sorted-setartifact appears to be unmaintained (last release: 0.3.0). Theorg.replikativ/persistent-sorted-setfork is actively maintained and version 0.3.118 preserves the sameme.tonsky.persistent-sorted-setClojure namespace — fully API-compatible, no code changes needed.This resolves classpath conflicts in projects that combine DataScript with Datahike, which already depends on the replikativ fork. Currently, both artifacts end up on the classpath with different group IDs for the same library, causing version resolution issues (especially when
org.replikativ/persistent-sorted-setresolves to 0.4.x which renamed the namespace toorg.replikativ.persistent-sorted-set).Testing
datascript.coreloads successfully with the new dependencyme.tonsky.persistent-sorted-setnamespace at 0.3.x