Skip to content

feat: ENG-92086 - call prewarm API after volume upload and image build - #535

Open
narasul wants to merge 1 commit into
mainfrom
prewarm
Open

feat: ENG-92086 - call prewarm API after volume upload and image build#535
narasul wants to merge 1 commit into
mainfrom
prewarm

Conversation

@narasul

@narasul narasul commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Call prewarm API after image build and volume upload.

@broly-code-security-scanner

Copy link
Copy Markdown

Broly Security Scan

Note

Clean scan
No vulnerabilities detected in this PR.

Note

Re-scan this PR anytime with /broly scan — useful after /broly undismiss, or to refresh findings without a new push.

Broly — SAST (zai-org/GLM-5.2) · Secrets · SCA · IaC · GH Actions · Base Images · Supply Chain Threats · Exploit Chains · Adversarial Verification

We're continuously improving Broly's accuracy and finding quality — your feedback is valuable. False positives, missed findings, bugs, and feature requests all welcome.

Ask in #security-engineering   Powered by Together AI

@narasul narasul changed the title Open ENG-92086 - call prewarm API after volume upload and image build feat: ENG-92086 - call prewarm API after volume upload and image build Aug 20, 2026
Comment on lines +647 to +649
except Exception as e:
if DEBUG:
console.print(f"Prewarm request failed: {e}")

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have top level CLI exception handling already, and it logs errors to our analytics. This is going to silently mute these exceptions to just local information. I think we could do without these 3 loc

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where can I see the those analytics errors?

We don't want customer to see anything if this call fails, this is best-effort; if we can get the the telemetry about it that is more than enough. Top level error handler still logs something normally right?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Top level error handler logs just the e.message, very similar to what this does. But it does always, not only in debug mode.

This is actually probably fine to keep. I thought it was the end of the command. If you want this to log to the analytics server you'd have to manually log it. with track_cli call. We'd probably need to add a new event also.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want this to log to the analytics server you'd have to manually log it. with track_cli call

yep, I'll do that then, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants