Conversation
Broly Security ScanNote ✅ Clean scan Note Re-scan this PR anytime with
|
| except Exception as e: | ||
| if DEBUG: | ||
| console.print(f"Prewarm request failed: {e}") |
There was a problem hiding this comment.
we have top level CLI exception handling already, and it logs errors to our analytics. This is going to silently mute these exceptions to just local information. I think we could do without these 3 loc
There was a problem hiding this comment.
Where can I see the those analytics errors?
We don't want customer to see anything if this call fails, this is best-effort; if we can get the the telemetry about it that is more than enough. Top level error handler still logs something normally right?
There was a problem hiding this comment.
Top level error handler logs just the e.message, very similar to what this does. But it does always, not only in debug mode.
This is actually probably fine to keep. I thought it was the end of the command. If you want this to log to the analytics server you'd have to manually log it. with track_cli call. We'd probably need to add a new event also.
There was a problem hiding this comment.
If you want this to log to the analytics server you'd have to manually log it. with track_cli call
yep, I'll do that then, thanks!
Call prewarm API after image build and volume upload.