Repository navigation
Align OpenHuman memory eval with 10-second deadline - #257
Merged
Merged
Conversation
Co-authored-by: Medulla <medulla@tinyhumans.ai>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Align the OpenHuman benchmark mirror with the proposed 10-second pre-turn memory deadline and record a fresh 1,000-document needle run. Historical 5-second measurements remain labeled as such.
The simple lexical owner question found the needle at rank 1 in 1.769 s. The semantic paraphrase missed in 1.767 s. Neither timed out. Direct CortexDB diagnostics attributed 1.067 s of a 1.101 s fresh simple recall to query embedding and 16 ms to vector search. Asking for 12, 24, or 100 events took 1.48, 1.49, and 1.43 s with fresh lexical phrasings. At this corpus size the external embedding call dominates; the longer deadline does not fix semantic ranking.
Related issue
Follow-up to #251. OpenHuman default change: tinyhumansai/openhuman#7368
API or behavior changes
No public API change. The benchmark's OpenHuman mirror waits up to 10 seconds for a pre-turn pack. Production OpenHuman changes in the related PR.
Validation
cargo fmt --all -- --check— passed.cargo clippy --all-targets --all-features -- -D warnings— passed.cargo build --all-targets --all-features— passed.cargo test --all-features— passed.Tests
The ten-second mirror assertion failed against the old five-second value, then passed after the change. The run used the existing deterministic needle fixture. Model answers were not requested; this comparison measures pack retrieval and timing.
Documentation
Updated
docs/evals/openhuman-host.mdwith the deadline distinction, 1,000-document results and CortexDB timing breakdown.Checklist
#[allow(...)],#[ignore], or relaxed lints..envcontents in the diff or the description.