feat: support proxy environment variables for OAuth requests#999
Conversation
Configure the OAuth HTTP transport with http.ProxyFromEnvironment so token exchange and userinfo requests respect HTTP_PROXY, HTTPS_PROXY and NO_PROXY.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe OAuth service configures its internal HTTP transport with ChangesOAuth proxy support
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
Thank you @florianilch! |
The OAuth service currently uses a custom
http.Transportto configure TLS.This change configures that transport to use also
http.ProxyFromEnvironmentto enableHTTP_PROXY,HTTPS_PROXYandNO_PROXYfor token exchange and userinfo requests. The existing TLS configuration and other transport behavior remain unchanged.Closes #998
Verification
make webui testand manual testSummary by CodeRabbit