Skip to content

feat(account-drawer) Made the landscape view and small screen view us… - #11488

Open
dani-zilla wants to merge 1 commit into
thunderbird:mainfrom
dani-zilla:11476-improve-account-drawer-small-displays
Open

feat(account-drawer) Made the landscape view and small screen view us…#11488
dani-zilla wants to merge 1 commit into
thunderbird:mainfrom
dani-zilla:11476-improve-account-drawer-small-displays

Conversation

@dani-zilla

@dani-zilla dani-zilla commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Contribution Summary

Linked Issue/Ticket: Fixes #11476

Description

The account drawer settings block the accounts and folders view on small displays, as well as in landscape view. This applies the icon-only landscape view with a horizontal row of icons for both landscape views as well as small screen sizes in any orientation.

It does not change how these display on any other screen sizes or orientations

Screen Shots

These are from a Sidephone, which is considered a "Small Screen" phone in landscape and portrait. Therefore, it always uses the icon-only version of the settings buttons.

accountDrawerFixSidephone

These are from a Motorola Razr. On the inner display, portrait orientation is exactly as it was before, while landscape is using the new improved landscape view that makes more room for the scrolling content. It's also not necessary on the outer display, as it's large enough to display the text for the buttons, but when using the outer display in portrait, it becomes narrow enough to meet the small screen criteria and displays the buttons without text.

razrAccountDrawerSmallScreenLandscapeImprovements

I found the expect orientation delivered the right button style in all the ways I tried, which included over 14 orientations on two devices, one with multiple display modes and the other small. These were just a few examples.

AI Disclosure

Select one of the following (mandatory)

  • This contribution does not include any changes created or assisted by AI.
  • This contribution includes changes assisted by AI.
  • This contribution includes changes created by AI.

Contribution Checklist

  • I have read and affirm that my contribution adheres to Mozilla’s Community Participation Guidelines
  • This contribution is in Kotlin where possible
  • This contribution does not use merge commits
  • This contribution adheres to the existing codestyle (run gradlew spotlessCheck to check and gradlew spotlessApply to format your source code; will be checked by CI).
  • This contribution does not break existing unit tests (run gradlew testDebugUnitTest; will be checked by CI).
  • This contribution includes tests for any new functionality, and maintains tests for any updated functionality.
  • This contribution adheres to our Engineering process (RFC/Technical Design/ADR)
  • This PR has a descriptive title and body that accurately outlines all changes made, and contains a reference to any issues that it fixes (e.g. Closes #XXX or Fixes #XXX).

…e a row of icons instead of a stack to preserve space.
@dani-zilla
dani-zilla requested a review from a team as a code owner September 3, 2026 00:54
@dani-zilla dani-zilla added the report: include Include changes in user-facing reports. label Sep 3, 2026
@github-actions github-actions Bot added the tb-team Tasks and features handled by project maintainers label Sep 3, 2026

@rafaeltonholo rafaeltonholo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

report: include Include changes in user-facing reports. tb-team Tasks and features handled by project maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve Account Drawer Scroll Area on Small Displays

2 participants