feat(account-drawer) Made the landscape view and small screen view us… - #11488
Open
dani-zilla wants to merge 1 commit into
Open
feat(account-drawer) Made the landscape view and small screen view us…#11488dani-zilla wants to merge 1 commit into
dani-zilla wants to merge 1 commit into
Conversation
…e a row of icons instead of a stack to preserve space.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution Summary
Linked Issue/Ticket: Fixes #11476
Description
The account drawer settings block the accounts and folders view on small displays, as well as in landscape view. This applies the icon-only landscape view with a horizontal row of icons for both landscape views as well as small screen sizes in any orientation.
It does not change how these display on any other screen sizes or orientations
Screen Shots
These are from a Sidephone, which is considered a "Small Screen" phone in landscape and portrait. Therefore, it always uses the icon-only version of the settings buttons.
These are from a Motorola Razr. On the inner display, portrait orientation is exactly as it was before, while landscape is using the new improved landscape view that makes more room for the scrolling content. It's also not necessary on the outer display, as it's large enough to display the text for the buttons, but when using the outer display in portrait, it becomes narrow enough to meet the small screen criteria and displays the buttons without text.
I found the expect orientation delivered the right button style in all the ways I tried, which included over 14 orientations on two devices, one with multiple display modes and the other small. These were just a few examples.
AI Disclosure
Select one of the following (mandatory)
Contribution Checklist
gradlew spotlessCheckto check andgradlew spotlessApplyto format your source code; will be checked by CI).gradlew testDebugUnitTest; will be checked by CI).