Repository navigation
Conversation
nyamsprod
force-pushed
the
feature/writer-quoting
branch
from
November 12, 2026 03:51
a716f68 to
dd0ddf0
Compare
nyamsprod
force-pushed
the
feature/writer-quoting
branch
from
November 12, 2026 03:59
dd0ddf0 to
de1122d
Compare
nyamsprod
force-pushed
the
feature/writer-quoting
branch
2 times, most recently
from
November 17, 2026 07:57
ea4ab1a to
dfb17f9
Compare
nyamsprod
force-pushed
the
feature/writer-quoting
branch
from
November 17, 2026 11:39
dfb17f9 to
1a3965c
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrite and simplify Writer quoting feature based on Python quoting constant,
see:
The following quoting type from Python are not backported to
league/csvbecause they have no counterpart in PHP.The escape character is never used outside of the
Quoting::Minimaltype which is the default type covered by PHP'sfputcsv.The following Enum is added:
alongside the following methods:
Writer::setQuoting(Quoting $quoting): WriterWriter::getQuooting(): QuotingAnd thus, the following methods are deprecated:
Writer::forceEnclosureWriter::noEnclosureWriter::necessaryEnclosureWriter::encloseAllWriter::encloseNecessaryWriter::encloseNoneBy default and to avoid BC break, the default quoting mechanism is
Quoting::Minimal