Repository navigation
Documentation: recommend the fpm variant with its built-in Apache, PHP-FPM pools and v6 roadmap - #427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Depends on #426 (this PR contains its commit, the diff will shrink once it is merged).
This PR is a maintenance update of the documentation:
php2shell is no longer the main news of the images. The README now highlights the fpm variant with its built-in Apache, the recommended way to serve a web application (2 to 3 times more traffic with 4 times less memory than
mod_php, see the benchmark):apachevariant comes last;docs/variants.mdrecommends the fpm variant for new applications;It also documents two questions of #190 in
docs/fpm.md:/var/www/html(APACHE_DOCUMENT_ROOTand working directory);LocationMatch+SetHandler) orby your own web server.
Fixes #190
Test plan (required)
Documentation only:
make blueprint, links checked. The examples ofdocs/fpm.mdwere run on a PHP 8.4 fpm image:/info.phpis served by thewwwpool (memory_limit=128M),/wp-admin/info.phpby theadminpool(
memory_limit=512M), a missing/wp-admin/*.phpfile gets a404, the workers of both pools run asdocker;/var/wwwwithAPACHE_DOCUMENT_ROOT=/var/www/publicis served;adminpool starts without warning.Checklist