Skip to content

fix(han-planning): correct two defects in the visual-material reference material - #190

Merged
mxriverlynn merged 1 commit into
v5.4.0-betafrom
fix/187-visual-material-reference-defects
Aug 20, 2026
Merged

fix(han-planning): correct two defects in the visual-material reference material#190
mxriverlynn merged 1 commit into
v5.4.0-betafrom
fix/187-visual-material-reference-defects

Conversation

@mxriverlynn

Copy link
Copy Markdown
Collaborator

Fixes the two defects reported in #187, both in han-planning reference material and both about how a planning run handles visual material.

The truncated invariant

plan-a-feature/references/artifact-invariants.md ended mid-clause on the Visual Reference invariant, stopping after the word "with". Step 8 tells the synthesizer to read that file and preserve the invariants it carries, so a run that received visual material was asked to preserve a rule whose definition was unfinished.

The missing clause was lost when the file was extracted from SKILL.md in d01abe6. I recovered it from that commit's parent, where the same invariant reads in full at line 655. It is restored verbatim: the table lists every item the boundary record records as received, under that exact heading, with an inline embed beside the prose describing each state.

The empty visual-material table

planning-boundary-rule.md said the Visual Material Received section takes None received when nothing arrived, then showed the section as a table with two illustrative rows. Nothing said the table itself goes away. A run that followed the shape it was shown wrote a placeholder row, and the Step 9 completeness gate refused it, because the gate reads every row as an item claimed on disk.

The rule now says None received stands alone and the table is omitted, and names the gate as the reason.

Verification

npm run lint passes. Both changes are prose in reference files with no script or schema behavior attached.

Closes #187.

…nd bound the empty visual table

artifact-invariants.md ended mid-clause on the Visual Reference
invariant, so a run that received visual material asked the synthesizer
to preserve a rule whose definition stopped after "with". Restores the
missing clause from the pre-extraction SKILL.md text: an inline embed
beside the prose describing each state.

planning-boundary-rule.md showed the Visual Material Received section as
a table with illustrative rows and never said the table is omitted when
nothing arrived. A run following that shape wrote a placeholder row and
the Step 9 completeness gate refused it. States that `None received`
stands alone and the table is omitted, and why.

Closes #187.
@mxriverlynn
mxriverlynn marked this pull request as ready for review August 20, 2026 14:47
@mxriverlynn
mxriverlynn merged commit 13c3cd3 into v5.4.0-beta Aug 20, 2026
2 checks passed
@mxriverlynn
mxriverlynn deleted the fix/187-visual-material-reference-defects branch August 20, 2026 14:47
mxriverlynn added a commit that referenced this pull request Aug 20, 2026
collecting updates for a v5.4.0 release

* #184 
* #186 
* #189
* #190
* #191
* #192 
* misc documentation updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant