Skip to content

Respect user-defined security protocol for additional Kafka listeners #12108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SamuelAdigos wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Respect user-defined security protocol for additional Kafka listeners #12108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions modules/kafka/src/main/java/org/testcontainers/kafka/KafkaHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
import java.util.Arrays;
import java.util.HashMap;
import java.util.List;
import java.util.Locale;
import java.util.Map;
import java.util.Set;
import java.util.function.Supplier;
Expand Down Expand Up @@ -78,9 +79,13 @@ static void resolveListeners(GenericContainer<?> kafkaContainer, Set<String> lis
String listenerHost = listener.split(":")[0];
String listenerPort = listener.split(":")[1];
String listenerProtocol = String.format("%s://%s:%s", protocol, listenerHost, listenerPort);
String protocolMap = String.format("%s:PLAINTEXT", protocol);
listeners.add(listenerProtocol);
listenerSecurityProtocolMap.add(protocolMap);
boolean securityProtocolConfigured = listenerSecurityProtocolMap
.stream()
.anyMatch(entry -> entry.trim().toUpperCase(Locale.ROOT).startsWith(protocol + ":"));
if (!securityProtocolConfigured) {
listenerSecurityProtocolMap.add(String.format("%s:PLAINTEXT", protocol));
}

String host = listener.split(":")[0];
kafkaContainer.withNetworkAliases(host);
Expand Down
24 changes: 24 additions & 0 deletions modules/kafka/src/test/java/org/testcontainers/kafka/ConfluentKafkaContainerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,30 @@ void testUsageWithListenerFromProxy() throws Exception {
}
}

@SneakyThrows
@Test
void shouldKeepSecurityProtocolConfiguredForListener() {
try (
Network network = Network.newNetwork();
SocatContainer socat = new SocatContainer().withNetwork(network).withTarget(2000, "kafka", 19092);
ConfluentKafkaContainer kafka = new ConfluentKafkaContainer("confluentinc/cp-kafka:7.7.0")
.withListener("kafka:19092", () -> socat.getHost() + ":" + socat.getMappedPort(2000))
.withNetwork(network)
.withEnv(
"KAFKA_LISTENER_SECURITY_PROTOCOL_MAP",
"BROKER:PLAINTEXT,PLAINTEXT:PLAINTEXT,CONTROLLER:PLAINTEXT,TC-0:SASL_PLAINTEXT"
)
.withEnv("KAFKA_LISTENER_NAME_TC-0_SASL_ENABLED_MECHANISMS", "PLAIN")
.withEnv("KAFKA_LISTENER_NAME_TC-0_PLAIN_SASL_JAAS_CONFIG", getJaasConfig())
) {
socat.start();
kafka.start();

String bootstrapServers = String.format("%s:%s", socat.getHost(), socat.getMappedPort(2000));
testSecurePlainKafkaFunctionality(bootstrapServers);
}
}

@SneakyThrows
@Test
void shouldConfigureAuthenticationWithSaslUsingJaas() {
Expand Down
Loading