chore(deps): Properly pass selected TLS implementation to reqwest - #1458
Merged
Conversation
mjameswh
force-pushed
the
deps/avoid-aws-lc-rs
branch
from
August 6, 2026 21:52
a3de87d to
2bc75f1
Compare
chris-olszewski
approved these changes
Aug 7, 2026
There was a problem hiding this comment.
Pull request overview
Switches reqwest TLS to ring by default, reducing native build and cross-compilation overhead.
Changes:
- Installs ring as the process-wide rustls provider.
- Updates ephemeral downloads and OTLP metrics initialization.
- Removes the duplicate reqwest dependency.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
crates/sdk-core/src/ephemeral_server/mod.rs |
Initializes the TLS provider before downloads. |
crates/sdk-core/Cargo.toml |
Reconfigures reqwest TLS features. |
crates/common/src/telemetry/otel.rs |
Initializes TLS before exporter construction. |
crates/common/src/telemetry.rs |
Adds provider initialization helper. |
crates/common/Cargo.toml |
Removes reqwest 0.12 and adds rustls ring support. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.
Suppressed comments (1)
crates/sdk-core/Cargo.toml:24
ephemeral-serverno longer guarantees a TLS-capable client when default features are disabled.--no-default-features --features ephemeral-servernow activatesreqwestwithout either TLS feature, whileEphemeralExe::CachedDownloadalways contactshttps://temporal.downloadand the new provider helper is a no-op in this configuration, so every cache miss fails. Please either make this feature combination select a TLS provider or explicitly reject the unsupported combination at compile time.
"reqwest?/rustls-no-provider",
mjameswh
enabled auto-merge (squash)
August 10, 2026 20:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
reqwest.temporalio-commonwas requiring 0.12, whiletemporalio-sdk-coreandopentelemetry-otlprequire 0.13, so any build enablingotelcompiled two incompatible versions ofreqwest.reqwestwhen used for OTEL, Ephemeral Server download, andDebugClient. Those were previously depending onaws-lc-rsdespite thetls-ringfeature, resulting in bothringANDaws-lc-rsbeing built and linked into the resulting binary. Undertls-ring,ringis now installed as the process-wide default rustlsCryptoProvideron first use, via the newtemporalio_common::telemetry::ensure_default_crypto_provider().Two reqwest clients end up with no compiled-in provider and resolve one from the process default at connection time: the ephemeral server downloader and the OTLP HTTP metric exporter. Both now call the new
temporalio_common::telemetry::ensure_default_crypto_provider()before use. It is idempotent, is a no-op unless built withtls-ringand withouttls-aws-lc, and tolerates another component having installed a provider first.Verification
Verified with
cargo tree --target all: noaws-lc-rsundertls-ring, noringundertls-aws-lc, and a singlereqwest. Full CI green, including the Docker integ (OTLP) tests.cargo tree -p temporalio-sdk-core --features ephemeral-server,otel --target all, before:after:
cargo check -p temporalio-sdk-core --test integ_tests --features temporalio-common/serde_serialize,test-utilities,ephemeral-server,otelcargo tree --target all, as above.