docs: logging example fix to go sdk observability page#4393
Open
ptdewey wants to merge 1 commit intotemporalio:mainfrom
Open
docs: logging example fix to go sdk observability page#4393ptdewey wants to merge 1 commit intotemporalio:mainfrom
ptdewey wants to merge 1 commit intotemporalio:mainfrom
Conversation
|
@ptdewey is attempting to deploy a commit to the Temporal Team on Vercel. A member of the Team first needs to authorize it. |
ptdewey
force-pushed
the
push-rospuqzvumwk
branch
from
a167d99 to
3d9d970
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Replaces the deprecated
logur/Logruscustom logger example with the SDK's built-inlog.NewStructuredLogger()+slogapproach (available since Go SDK v1.25.0). Adds a zap-via-zapslog example showing how any third-party logger with anslog.Handlercan be bridged, and a pointer to the samples-go zap adapter for directlog.Loggerimplementations.Closes #4356
Screenshot of relevant section:
┆Attachments: EDU-6165 docs: logging example fix to go sdk observability page