Repository navigation
Conversation
dnr
commented
Oct 9, 2026
| // workers will not increase throughput — the bottleneck is the rate limit, not worker count. This | ||
| // field is useful for auto-scaling systems to avoid unnecessary scale-up. | ||
| bool rate_limiting_active = 5; | ||
| bool flow_control_active = 6; |
Contributor
Author
There was a problem hiding this comment.
This is worth some discussion: there are now more things than rate limits that can deliberately slow dispatch. But we probably don't want to add a separate field for each kind of thing (e.g. circuit_breaker_active, adaptive_limiter_active, ...). So maybe we want a bunch of type-specific bools plus one "any flow control active" bool, and then update code to mostly look at that one new one, and the type-specific ones are just for debugging/observability?
I considered changing rate_limiting_active to flow_control_active, but that's an incompatible change (at the json/source level, not the wire level).
@carlydf @rkannan82 you may have thoughts on this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Add whole-queue concurrency limit config to task queue config.
Why?
Simplest possible concurrency limit. Server-side implementation is easier to manage than worker slots.