fix(react): allow null controlled RadioGroup values#3863
Open
raashish1601 wants to merge 1 commit intotailwindlabs:mainfrom
Open
fix(react): allow null controlled RadioGroup values#3863raashish1601 wants to merge 1 commit intotailwindlabs:mainfrom
raashish1601 wants to merge 1 commit intotailwindlabs:mainfrom
Conversation
|
@raashish1601 is attempting to deploy a commit to the Tailwind Labs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RadioGroupto acceptnullas the controlled empty value again without broadeningonChangeto nullable valuesuseControllableso the selected value can staynulluntil an option is chosennull -> stringcontrolled flow updates without triggering the uncontrolled-to-controlled warningTesting
npx prettier --check packages/@headlessui-react/src/hooks/use-controllable.ts packages/@headlessui-react/src/components/radio-group/radio-group.tsx packages/@headlessui-react/src/components/radio-group/radio-group.test.tsxnpx jest packages/@headlessui-react/src/components/radio-group/radio-group.test.tsx --config packages/@headlessui-react/jest.config.cjs --runInBandnpx tsc --pretty false --noEmit --jsx react-jsx --module esnext --moduleResolution node --target esnext --strict --esModuleInterop --skipLibCheck false ./.tmp-headlessui-3844-dist.tsx(run against the built@headlessui/reactpackage withvalue={selected ?? null})../../scripts/build.sh --external:react --external:react-dom --external:use-sync-external-storefrompackages/@headlessui-reactunder Git Bash with the workspacenode_modules/.binonPATHCloses #3844.