Fix search crash on API 32 and older - #796
Open
Pawloland wants to merge 3 commits into
Open
Conversation
Signed-off-by: Pawloland <59684145+Pawloland@users.noreply.github.com>
Contributor
Author
|
@kari-ts I hate to be that guy, but is there any hope of merging it? |
# Conflicts: # android/src/main/java/com/tailscale/ipn/ui/view/SearchView.kt
Contributor
Author
|
@bradfitz Also fixed merge conflicts, so it can also be merged |
Signed-off-by: Pawloland <59684145+Pawloland@users.noreply.github.com>
bradfitz
approved these changes
Jul 28, 2026
Collaborator
|
Thanks for the fix! Sorry for the delay in reviewing. Could you please rebase onto current main and keep just the compatibility fix instead of merging this as is? It looks like there is merge conflict resolution that is no longer relevant (eg bringing in older |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It should fix https://github.com/tailscale/corp/issues/27375, but I don't have access to it, so I didn't mention it in the commit message. This commit basically fixes a crash that prevented the search function from working on older Android versions, like Android 11.