Conversation
There was a problem hiding this comment.
Pull request overview
Updates the laptop and desktop hardware testing templates to explicitly include DMI verification in the standard checklist, and cleans up some Markdown structure so the templates render more consistently.
Changes:
- Added a new “DMI Values” checklist section (with a notes/issues subsection) to both desktop and laptop testing templates.
- Standardized top-level “Test Platform” to an H1 header and improved spacing around the checklist header.
- Adjusted/clarified a couple of subsection headings (and removed minor trailing whitespace in the desktop template).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| laptops/laptop_testing_template.md | Adds DMI verification checklist + notes section; normalizes heading levels and subsection labels. |
| desktops/desktop_testing_template.md | Adds DMI verification checklist + notes section; normalizes heading level and minor formatting cleanup. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
leviport
approved these changes
Aug 17, 2026
leviport
left a comment
leviport
left a comment
Member
There was a problem hiding this comment.
This has historically been more of an unspoken criteria for firmware PRs, but adding it to cert checklist is a nice safeguard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.