Repository navigation
Name the whiteboard pens and mark the one in use - #279
Merged
Merged
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
LeafYeh1
marked this pull request as draft
October 11, 2026 15:16
LeafYeh1
force-pushed
the
whiteboard-pen-names
branch
from
October 11, 2026 15:19
f8f12d5 to
fa596de
Compare
jserv
reviewed
Oct 11, 2026
LeafYeh1
force-pushed
the
whiteboard-pen-names
branch
from
October 11, 2026 15:51
fa596de to
16f16c9
Compare
LeafYeh1
marked this pull request as ready for review
October 11, 2026 15:52
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
ColtenOuO
reviewed
Oct 11, 2026
Each pen swatch was named after its hex value, so VoiceOver read out "Pen #101418" and Voice Control expected it spoken, and the selected pen was marked only by a class that assistive technology cannot see. Give each pen a color name and draw the swatch's ring from aria-pressed, as the eraser sizes already do, so the state that is drawn and the state that is announced cannot disagree. Closes sysprog21#274
LeafYeh1
force-pushed
the
whiteboard-pen-names
branch
from
October 12, 2026 03:45
16f16c9 to
161fb60
Compare
Contributor
|
Thank @LeafYeh1 for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each pen swatch was named from its hex value, so VoiceOver read "Pen #101418" character by character and Voice Control expected it spoken, and the selected pen was marked only by a
selectedclass that assistive technology cannot see. The swatches now take a color name ("Black pen", "Red pen", ...) fromPEN_COLORS, andpaintToolStatesetsaria-pressedon them as it already does for the eraser and its sizes. The ring around the selected swatch is drawn fromaria-pressedinstead of the class, the same way.board-sizeis, so the drawn state and the announced state cannot disagree.tests/browser/whiteboard-toolbar.test.jsfinds each pen by its accessible name, then after picking a pen and then the eraser asks the whole toolbar which buttons report themselves pressed and checks which pens are drawn with the ring; onmainit fails because no button is named "Black pen"../scripts/test.shpasses locally; the lanes it skipped here (Java, cargo-audit, actionlint, ruff, shellcheck) do not cover this change.Closes #274