feat: convert scanner to bottom sheet#840
Conversation
This comment has been minimized.
This comment has been minimized.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
app/src/main/java/to/bitkit/ui/screens/settings/ProbingToolScreen.kt
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
drafted to investigate e2e failure |
|
@piotr-iohk I see "127.0.0.1:6001:s" on the input of this test. Is it expected? |
…t's dismiss animation
Fixed Screen_recording_20260316_081300.webmScreen_recording_20260316_081406.webm |
Probably fixed for that flow: But my flow: No QuickPay + use camera to scan still has a bug: Not sure if this was a bug on |
This comment was marked as outdated.
This comment was marked as outdated.
|
Confirmed this is a pre-existing bug on master — the Created #849 to track the fix. |
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
|
Retested ✅ |
ovitrif
left a comment
There was a problem hiding this comment.
retested all flows 👏🏻
LGTM ![]()
Thanks for the thorough investigation and filing the bug about unified invoice scan 🥇 .
FIGMA
This PR converts the QR scanner from a full-screen navigation route into a proper bottom sheet, consistent with other sheets in the app (Send, Receive, Backup, etc).
Description
NavControllerdependency fromQrScanningScreenand simplifies it to acceptonBack/onScanSuccesscallbacksQrScanningSheetthat wraps the scanner in aSheetHost-compatible composable withsheetHeight()Sheet.QrScannertype and result routing viaAppViewModel.showScannerSheet(onResult)Routes.QrScannernavigation route andnavigateToScanner()extensioninSheetconditional styling from scanner and camera permission views, always using sheet stylingPreview
normal-payment.mp4
send-sheet.mp4
probing.mp4
quickpay.mp4
QA Notes