Skip to content

chore: remove polka from adapter-node - #16907

Open
Nic-Polumeyv wants to merge 2 commits into
version-3from
remove-polka
Open

chore: remove polka from adapter-node#16907
Nic-Polumeyv wants to merge 2 commits into
version-3from
remove-polka

Conversation

@Nic-Polumeyv

Copy link
Copy Markdown
Contributor

adapter-node uses polka for a single .use(handler) call. The middleware chain polka would manage is already hand-rolled in src/handler.js (sequence), and src/index.js pre-creates the http.Server to work around polka's lazy server creation, so at runtime polka only attaches one listener and forwards listen(). The dependency has also been pinned to a prerelease (1.0.0-next.28) for years.

This attaches handler to the request event directly and drops the dependency. The server export of the built entry is now the http.Server itself rather than the polka instance. Also deletes smoke.spec_disabled.js, which imported polka along with a create_kit_middleware that no longer exists.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@pkg-svelte-dev

pkg-svelte-dev Bot commented Aug 22, 2026

Copy link
Copy Markdown

Install the latest version of @sveltejs/kit from 1f3a3b3:

pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/1f3a3b3483060eef6ff15456ebb9d8d661124e55

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/kit/pr/16907

@changeset-bot

changeset-bot Bot commented Aug 22, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 1f3a3b3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/adapter-node Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant