test: stabilize async remote mutation tests - #16896
Draft
svelte-triage-bot[bot] wants to merge 1 commit into
Draft
test: stabilize async remote mutation tests#16896svelte-triage-bot[bot] wants to merge 1 commit into
svelte-triage-bot[bot] wants to merge 1 commit into
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/a4252909c77a1117b01a588c653a6919f3fcbca2Open in Note This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two pre-existing async e2e flakes exposed by the CI run for #16892.
The form reconnect test previously polled a server-side iterator cleanup counter. The failed traces show that the form response succeeded and the targeted
get_countconnection restarted, but transport cleanup had not updated the counter within the assertion window. Assert the observable reconnect requests directly instead, including thatget_finite_countis not reconnected.The serial batch tests also retained module-level todo mutations across retries. Reset the todos before asserting the baseline state so reruns are idempotent.
Failed workflow: https://github.com/sveltejs/kit/actions/runs/32541364509
Verification:
pnpm -F test-async check