fix: allow caret placement inside commented text on click (SD-2442)#2708
Open
luccas-harbour wants to merge 2 commits intomainfrom
Open
fix: allow caret placement inside commented text on click (SD-2442)#2708luccas-harbour wants to merge 2 commits intomainfrom
luccas-harbour wants to merge 2 commits intomainfrom
Conversation
caio-pizzol
reviewed
Apr 3, 2026
Contributor
caio-pizzol
left a comment
There was a problem hiding this comment.
@luccas-harbour fix looks good, no bugs found. clicking on commented text places the caret correctly and the right comment gets selected — tested all the cases (single comment, overlapping comments, re-clicking same comment).
one side effect: clicking commented text highlights the comment bubble but doesn't open the reply thread like google docs does. filed SD-2460 for that — not a blocker here.
left one small inline comment on the test helpers.
| throw new Error(`Could not resolve coordinates for document position ${pos}`); | ||
| } | ||
|
|
||
| return coords; |
Contributor
There was a problem hiding this comment.
this math always simplifies to coords.left + 1 — the min/max wrapping doesn't do anything. same thing in rightClickAtDocPos below. worth simplifying?
Suggested change
| return coords; | |
| const x = coords.left + 1; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sd-2442-commented-text-caret.spec.ts) and updates existing unit tests to reflect the new behavior