test(cli): stabilize domains parity e2e#5548
Open
jgoux wants to merge 1 commit into
Open
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 011ce1b505
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Supabase CLI previewnpx --yes https://pkg.pr.new/supabase@5548Preview package for commit |
jgoux
force-pushed
the
fix/domains-parity-stderr
branch
3 times, most recently
from
6e20f89 to
2266691
Compare
jgoux
force-pushed
the
fix/domains-parity-stderr
branch
from
2266691 to
91be2dd
Compare
Coly010
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a domains parity failure seen in the merge queue: https://github.com/supabase/cli/actions/runs/27341219425/job/80778254211
The failing domains case compared
domains get --project-ref ... --output json. The Go CLI still writes the custom-hostname status line to stderr in machine-output mode, and because that status has no trailing newline it was sometimes hidden only when Go also printed an upgrade notice that the parity normalizer stripped. When that upgrade-check side effect was absent, the same command produced a stderr mismatch.This makes the domains parity expectation explicit by adding a generic, channel-aware normalization hook and keeping the Go custom-hostname patterns local to the domains e2e test. The strip only applies to stderr, so parity will still fail if a command pollutes structured stdout with human status text.
This also fixes a later functions-dev e2e failure from CI: https://github.com/supabase/cli/actions/runs/27352417825/job/80817569233. The test edited function source and immediately asserted the updated response without waiting for the file watcher restart corresponding to that edit. It now waits for the next function-file restart before polling the function endpoint.
While exercising the e2e suite locally, CLI subprocesses were also inheriting agent-detection environment variables from the developer shell, which changed output rendering and made local e2e behavior differ from CI. The e2e helpers now sanitize inherited agent-detection env by default while still allowing tests to opt in through explicit per-test env overrides.