Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description includes:
○Contributor name and NetID/email (1.5 pts):
michalb3 michalb3@illinois.edu
○Type of contribution (dataset+task/model/task) (1 pt):
dataset+task+model
○Link to original paper (required for reproducibility contributions) (1 pt):
https://arxiv.org/abs/2304.13017
○High-level description of implementation (1.5 pts):
This PR introduces a PyHealth-compliant full-pipeline integration of DuETT, representing a partial replication of the original paper.
○File guide listing which files to review (1 pt):
pyhealth/datasets/physionet2012.py: Core dataset loader and parser.pyhealth/datasets/configs/physionet2012.yaml: Dataset schema configuration.pyhealth/tasks/physionet_mortality.py: Task definition and time-binning logic.pyhealth/processors/duett_processor.py: Custom feature processor for Z-score normalization and observation counts.pyhealth/models/duett.py: Core DuETT model and dual-attention architecture.pyhealth/datasets/__init__.py,pyhealth/tasks/__init__.py,pyhealth/processors/__init__.py,pyhealth/models/__init__.pyexamples/physionet2012_mortality_duett.py: Ablation study and usage example.runner.sh: Local execution script for the pipeline.tests/core/test_physionet2012.py: Dataset parsing tests.tests/core/test_physionet_mortality.py: Task extraction and binning tests.tests/core/test_duett_processor.py: Processor normalization tests.tests/core/test_duett.py: Model forward-pass and instantiation tests.docs/api/datasets/pyhealth.datasets.PhysioNet2012Dataset.rstdocs/api/tasks/pyhealth.tasks.PhysioNetMortalityTask.rstdocs/api/processors/pyhealth.processors.DuETTTimeSeriesProcessor.rstdocs/api/models/pyhealth.models.DuETT.rstdocs/api/datasets.rst,docs/api/tasks.rst,docs/api/models.rst: Index updates to render the new documentation pages.○Follows example PR format from contribution guide (1 pt)