Repository navigation
feat: add client cleanup and context manager support - #429
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SDK owns an HTTPX client but provides no public cleanup API. Add
close()andaclose(), plus synchronous and asynchronous context managers, so scripts and applications can release connections reliably.Update the generator template, lifecycle documentation, and Flask/FastAPI examples. Tests cover transport cleanup, repeated closure, exception propagation, and rejection of requests after closure.
Supersedes #428 by @sumitsharma01. The original commit is preserved 265ce4b, followed by the example, documentation, and test improvements in 369282c.
Supersedes: #428