Repository navigation
Silence method redefined warning in aggregate update exception test - #1489
Conversation
Remove the singleton method before redefining it so Ruby doesn't warn when stubbing and restoring DuckDB::Converter._to_date. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to This test-only change preserves the conversion method during normal cleanup. No actionable merge-blocking risk remains. Pre-merge checks |
|
AggregateUpdateExceptionTest#with_conversion_raisingreplacesDuckDB::Converter._to_datewithdefine_singleton_methodand restores it the same way. Both steps redefine an existing method, sorake testprints:This removes the singleton method before each redefinition, so no warning is emitted. Test behavior is unchanged.
Minitest's
stubwas not used because Minitest 6 moved it into the separateminitest-mockgem.Testing
ruby -w -Ilib:test test/duckdb_test/aggregate_update_exception_test.rb: 3 runs, 0 failures, no warningsrubocopon the file: no offenses🤖 Generated with Claude Code
Summary by CodeRabbit