docs(isthmus): javadoc for io.substrait.isthmus.expression classes#764
Merged
bestbeforetoday merged 1 commit intosubstrait-io:mainfrom Mar 24, 2026
Merged
Conversation
Signed-off-by: MBWhite <whitemat@uk.ibm.com>
mbwhite
changed the title
nielspardon
changed the title
bvolpato
reviewed
Mar 24, 2026
Comment on lines
+90
to
93
| * | ||
| * <p>Missing {@code ScalarFunctionConverter} and {@code CallConverters.CREATE_SEARCH_CONV}. | ||
| */ | ||
| public RexExpressionConverter() { |
Member
There was a problem hiding this comment.
Maybe we make those package-private and bring a @VisibleForTesting contention over?
Member
There was a problem hiding this comment.
I agree that anything visible only for testing should ideally be default scope rather than public. Ideally the code would be testable without requiring test-only visibility but I appreciate that it is sometimes necessary / preferred.
bvolpato
approved these changes
Mar 24, 2026
Member
bvolpato
left a comment
bvolpato
left a comment
There was a problem hiding this comment.
LGTM, just one nit that you can choose to ignore
Contributor
Author
|
thanks @bvolpato good idea - but perhaps best to do in a dedicated test related PR... |
Member
|
I agree that this PR should stay focused on updating the Javadoc and code changes should happen in a separate PR, so I will merge as-is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.